feat: switch gateway image to distroless base#1004
Closed
dimityrmirchev wants to merge 1 commit intoNVIDIA:mainfrom
Closed
feat: switch gateway image to distroless base#1004dimityrmirchev wants to merge 1 commit intoNVIDIA:mainfrom
dimityrmirchev wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Replace the Ubuntu-based gateway image with gcr.io/distroless/cc-debian13 to minimize attack surface and image size.
|
Thank you for your interest in contributing to OpenShell, @dimityrmirchev. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the Ubuntu-based gateway image with gcr.io/distroless/cc-debian13 to minimize attack surface and image size. In addition removes the migration scripts as those are embedded into the gateway binary.
Let me know what do you think about this change and if you are willing to accept such contribution.
Related Issue
I did not find an issue about this, however I can open one if you advise so.
Changes
nonrootuser. IMO it is a matter of preference so I kept the originalopenshelluser. If agreed, I can switch to distroless'snonrootuser.Testing
mise run pre-commitpassesmise run clusterandmise run sandbox. Verified that the gateway works as expected.Checklist